Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new token kind "id" and use it for css id's (surprise) #27

Merged
merged 3 commits into from Jun 11, 2013

Conversation

noprompt
Copy link
Contributor

@noprompt noprompt commented Jul 4, 2012

This is something that has been bugging me for a little bit. While I can understand the use of constant, I think id should be correct token.

In tandem with this, I'm curious about changing the result of type to tag for css selectors. It would make sense in conjunction with HTML and create consistent output. Think of input[type="text"] and <input type="text">. Right now the css scanner sees input as a type and the html scanner see's it as tag. Should they really be tokenized differently?

What do you think?

@ghost ghost assigned korny Jul 6, 2012
@korny
Copy link
Member

korny commented Jul 6, 2012

Good thinking. "ID" sounds like something that could be useful for other languages, too.

Changing :type to :tag also seems like a good idea. I'll try it out.

@noprompt
Copy link
Contributor Author

noprompt commented Jul 6, 2012

Awesome! I've played with the type as tag concept and really like that output. Should I commit that as well?

Oh, I've also been doing a little work on the attribute selector output, but that's probably for another issue. :)

@korny
Copy link
Member

korny commented Jul 23, 2012

Yes, please :-)

@noprompt
Copy link
Contributor Author

No sweat. Thanks!

@korny korny merged commit 4eb4324 into rubychan:master Jun 11, 2013
@korny
Copy link
Member

korny commented Jun 11, 2013

Merged, with a few tweaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants