Create a new token kind "id" and use it for css id's (surprise) #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that has been bugging me for a little bit. While I can understand the use of
constant
, I thinkid
should be correct token.In tandem with this, I'm curious about changing the result of
type
totag
for css selectors. It would make sense in conjunction with HTML and create consistent output. Think ofinput[type="text"]
and<input type="text">
. Right now the css scanner seesinput
as atype
and the html scanner see's it astag
. Should they really be tokenized differently?What do you think?