Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rubygems deprecation #246

Merged
merged 1 commit into from May 29, 2020
Merged

Fix rubygems deprecation #246

merged 1 commit into from May 29, 2020

Conversation

deivid-rodriguez
Copy link
Contributor 

NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.
Gem::Specification#rubyforge_project= called from /home/deivid/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/specifications/coderay-1.1.2.gemspec:21.

@deivid-rodriguez
Fix rubygems deprecation
21b7ae8 
```
NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.
Gem::Specification#rubyforge_project= called from /home/deivid/.rbenv/versions/2.4.9/lib/ruby/gems/2.4.0/specifications/coderay-1.1.2.gemspec:21.
```
@codeclimate
Copy link

codeclimate bot commented Jan 18, 2020

Code Climate has analyzed commit 21b7ae8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 76.3% (-1.2% change).

View more on Code Climate.

@djberg96
Copy link
Contributor

djberg96 commented Mar 2, 2020

👍

Any chance you could also include the issues I mention in #235?

@deivid-rodriguez
Copy link
Contributor Author

@djberg96 Yeah, I'm happy to include more improvements. But I'd rather wait for some input from maintainers first, since I already have two pending PRs here.

@deivid-rodriguez
Copy link
Contributor Author

Hello @korny 👋 👋!

We plan to fix this warning in rubygems to not reach final users but only gem authors, but in any case it would be good to fix this in the coderay side.

This should be straightforward to review and merge, rubyforge hasn't existed for a very long time, any chance of finding some time to have a look?

@grosser
Copy link

grosser commented May 29, 2020

@korny can yo plz merge / release ... these warnings are noisy :(

@korny korny self-assigned this May 29, 2020
@korny
Copy link
Member

korny commented May 29, 2020

Damn! Sorry guys. I will merge it now.

@korny korny merged commit 9079074 into rubychan:master May 29, 2020
@korny korny added this to the quickfixes milestone May 29, 2020
@deivid-rodriguez deivid-rodriguez deleted the fix_rubygems_deprecation branch May 29, 2020 09:00
@grosser
Copy link

grosser commented May 29, 2020

any plans for a new release ?

@korny
Copy link
Member

korny commented May 30, 2020

1.1.3 is released now.

@grosser
Copy link

grosser commented May 30, 2020

thx! finally no more warnings 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@korny korny

Labels
None yet
Projects
None yet
Milestone
quickfixes
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deivid-rodriguez @djberg96 @grosser @korny