Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Translation Progress #2033

Open
JuanitoFatas opened this issue Apr 11, 2019 · 3 comments
Open

Feature: Translation Progress #2033

JuanitoFatas opened this issue Apr 11, 2019 · 3 comments

Comments

@JuanitoFatas
Copy link
Member

Context: #2032 (comment)

@stomar
Copy link
Contributor

stomar commented Apr 22, 2019

I do not see yet how this is supposed to work in practice. Using the commit hash would not be possible nor would it help.

@yous
Copy link
Member

yous commented Apr 23, 2019

This is how I understand:

  1. Let's say I translated "en/news/_posts/2019-04-23-move-to-git-from-svn.md" right after the merge of Announce Moving Ruby repository to Git #2050
  2. Then in the "ko/news/_posts/2019-04-23-move-to-git-from-svn.md", there would be either commit: 992af44 (the last commit of the pull request) or commit: e020291 (the merge commit)
  3. Then in master branch, someone updates the "en/news/_posts/2019-04-23-move-to-git-from-svn.md" (like cdade5d)
  4. After some time, translators run git diff 992af44 -- en/news/_posts/2019-04-23-move-to-git-from-svn.md (or using e020291) to see if there are updates, and then diff will show the content of cdade5d

Edit: For the step 2, translators can use git log -- en/news/_posts/2019-04-23-move-to-git-from-svn.md to see the latest commit for that file. Right after the merge, it'll show 992af44.

@stomar
Copy link
Contributor

stomar commented Apr 27, 2019

That probably could work (but relies heavily on the thoroughness of the translators).

I misunderstood the proposed system, because the given example also added a commit field in the en file, which wouldn‘t work for a commit hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants