Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundler-2.4 requires Ruby 2.6 or later #423

Merged
merged 1 commit into from Dec 24, 2022
Merged

Bundler-2.4 requires Ruby 2.6 or later #423

merged 1 commit into from Dec 24, 2022

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Dec 24, 2022

Resolved #422

@hsbt hsbt mentioned this pull request Dec 24, 2022
Closed
2 tasks
@MSP-Greg
Copy link
Collaborator

MSP-Greg commented Dec 24, 2022 •
edited by hsbt

Thanks for a PR on Christmas Eve (Happy Holidays/Merry Christmas!)

Not my call, but...

Would it be better to force install of RG 3.2.3 (which correctly handles required_ruby_version), rather than force a bundler version? I think that can be done such that it leaves Ruby 2.6 and later alone. I think I can do that quickly...

eregon
eregon approved these changes Dec 24, 2022
View reviewed changes
Copy link
Member

@eregon eregon left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@eregon eregon merged commit 8d6236c into master Dec 24, 2022
@hsbt hsbt deleted the use-bundler-2-3-for-ruby-2-5 branch December 24, 2022 22:32
@hsbt
Copy link
Member Author

hsbt commented Dec 24, 2022

Hi Greg, Eregon, Happy Holidays and Thanks for all your works for Ruby.

Would it be better to force install of RG 3.2.3 (which correctly handles required_ruby_version), rather than force a bundler version?

It's not needed yet. Because RubyGems is internally usage different with Bundler by Ruby users.

@eregon
Copy link
Member

eregon commented Dec 24, 2022

@MSP-Greg That would choose the same Bundler version, but also update RubyGems which users unlikely have done locally to the same version + a more risky change

@eregon
Copy link
Member

eregon commented Dec 25, 2022

https://github.com/ruby/setup-ruby/releases/tag/v1.129.0

@deivid-rodriguez deivid-rodriguez mentioned this pull request Dec 25, 2022
Merged
@renovate renovate bot mentioned this pull request Oct 11, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruby 2.3 to 2.5 can't install bundler
3 participants
@hsbt @MSP-Greg @eregon