Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong inputrc loading order #634

Open
tompng opened this issue Jan 6, 2024 · 0 comments
Open

Wrong inputrc loading order #634

tompng opened this issue Jan 6, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tompng
Copy link
Member

tompng commented Jan 6, 2024

Description

# Reline.readline
IOGate.prep
read inputrc
IOGate.deprep
# Reline.readline
IOGate.prep
read inputrc
IOGate.deprep

Order problem bug:
Reline reads inputrc after IOGate.prep.
config is not initialized on the first IOGate.prep call.

It will be a problem when implementing bracketed paste.

def prep
  # Enable bracketed paste
  @@output.write "\e[?2004h" if Reline.core.config.enable_bracketed_paste # this config is not initialized yet
end

Performance problem:
Readline seems to read inputrc only once. (warns if inputrc has a problem only once, no warning on inputrc edited after first load)
Reline reads inputrc on every Relin.readline call.

Terminal Emulator

Terminal.app
Not related to terminal emulator

@tompng tompng added bug Something isn't working good first issue Good for newcomers labels Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Development

No branches or pull requests

1 participant