Performance improvement #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDoc::Parser::C#find_body parsed file_content every time to find the method body. Now it creates a method-body table first, which avoid mutliple parsing.
Time.parse is painfully slow.
RDoc::RubyLex#getc is the bottleneck in RDoc. It determined which ungetc buffer to use by branching upon `@here_header`. We can remove the branch by replacing `@here_header` flag with `@current_readed`, which represents the current buffer directly,
|
I confirmed to reduce elapsed time from 78 sec to 57 sec with my env. |
|
Thank you! |
hsbt
added a commit
that referenced
this pull request
Apr 29, 2016
…ment"" This reverts commit 5203a65.
|
Sorry for no reply! I meant to comment sooner. Thank you for understanding and patch mame-san!! |
hsbt
added a commit
that referenced
this pull request
May 22, 2016
…ment"" This reverts commit 5203a65.
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces MRI's
maketime from 70 sec. to 45 sec. on my machine.