Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rdoc does not serve darkfish CSS #359

Closed
awood opened this issue Jul 31, 2015 · 2 comments
Closed

Rdoc does not serve darkfish CSS #359

awood opened this issue Jul 31, 2015 · 2 comments
Labels

Comments

@awood
Copy link
Contributor

awood commented Jul 31, 2015

Hi,

I'm running on Fedora 22, and when I run ri --serve the generated rdoc requests /css/rdoc.css which the WEBrick servlet cannot find.

My procedure to reproduce is

  1. sudo dnf install ruby-devel rubygem-rdoc
  2. gem install highline --ri --rdoc
  3. ri --serve

When I go to localhost:8214, the page is served but the CSS cannot be found. Here are the relevant messages from WEBrick

[2015-07-31 11:42:41] INFO  WEBrick 1.3.1
[2015-07-31 11:42:41] INFO  ruby 2.2.2 (2015-04-13) [x86_64-linux]
[2015-07-31 11:42:41] INFO  WEBrick::HTTPServer#start: pid=3552 port=8214
localhost.localdomain - - [31/Jul/2015:11:42:56 EDT] "GET / HTTP/1.1" 200 3200
- -> /
localhost.localdomain - - [31/Jul/2015:11:43:01 EDT] "GET /css/fonts.css HTTP/1.1" 404 2048
http://localhost:8214/ -> /css/fonts.css
localhost.localdomain - - [31/Jul/2015:11:43:01 EDT] "GET /css/rdoc.css HTTP/1.1" 404 2048
http://localhost:8214/ -> /css/rdoc.css
localhost.localdomain - - [31/Jul/2015:11:43:01 EDT] "GET /js/search_index.js HTTP/1.1" 200 361
http://localhost:8214/ -> /js/search_index.js
localhost.localdomain - - [31/Jul/2015:11:43:01 EDT] "GET /favicon.ico HTTP/1.1" 404 2056
- -> /favicon.ico

I see in the darkfish template that the CSS is being served off css/rdoc.css, but in the servlet.rb, the case statement is matching on /rdoc.css

There are also some problems with the JS when I request the rdoc for an actual gem:

localhost.localdomain - - [31/Jul/2015:11:52:02 EDT] "GET /highline-1.7.2/js/navigation.js HTTP/1.1" 404 3912
http://localhost:8214/highline-1.7.2/ -> /highline-1.7.2/js/navigation.js
localhost.localdomain - - [31/Jul/2015:11:52:02 EDT] "GET /highline-1.7.2/js/searcher.js HTTP/1.1" 404 3910
localhost.localdomain - - [31/Jul/2015:11:52:02 EDT] "GET /highline-1.7.2/js/search.js HTTP/1.1" 404 3908
@awood
Copy link
Contributor Author

awood commented Aug 3, 2015

The problems with the JS are located in darkfish.js. servlet.rb is only equipped to handle requests like /js/search.js but the req.path coming in is /highline-1.6.21/js/search.js

@zzak
Copy link
Member

zzak commented Dec 22, 2015

I think this was caused by #335... sorry!

@zzak zzak added the Bug label Dec 22, 2015
@zzak zzak closed this as completed in 4d81a1e Mar 23, 2016
zzak pushed a commit that referenced this issue Mar 23, 2016
Fix broken links to assets.  Fixes #359.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants