Do not store full path in GZipped js files. #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This relates to #334 |
|
ping ... can this be accepted please? This is still issue. |
|
@voxik Sorry for the delay! I will be spending some time this summer on RDoc, and will get this into the next release. |
|
That's a good news. Thank you. |
zzak
pushed a commit
that referenced
this pull request
Dec 20, 2015
Do not store full path in GZipped js files.
hsbt
referenced
this pull request
in ruby/ruby
Dec 22, 2015
https://github.com/rdoc/rdoc/pull/340 https://github.com/rdoc/rdoc/pull/341 https://github.com/rdoc/rdoc/pull/367 https://github.com/rdoc/rdoc/pull/368 * lib/rdoc/*: ditto. * test/rdoc/*: ditto. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53238 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
mrkn
referenced
this pull request
in mrkn/ruby
Apr 17, 2016
https://github.com/rdoc/rdoc/pull/340 https://github.com/rdoc/rdoc/pull/341 https://github.com/rdoc/rdoc/pull/367 https://github.com/rdoc/rdoc/pull/368 * lib/rdoc/*: ditto. * test/rdoc/*: ditto. git-svn-id: svn+ssh://svn.ruby-lang.org/ruby/trunk@53238 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cause issues in RPM packaged gems in Fedora, since the files, there appears full path with installation prefix, while in reality, they are later installed on different place. E.g. during package build of Hub [1], the documentation is generated into
/builddir/build/BUILDROOT/hub-1.12.1-3.fc22.noarch/usr/share/doc/hubdirectory, while the/builddir/build/BUILDROOT/hub-1.12.1-3.fc22.noarchprefix is later on stripped when the resulting RPM is generated. This cause issues such as:Aside from this particular issue, I really wonder why generation of the GZipped js files is not just optional. As far as I can say, they are not useful when the documentation is browsed just locally. In this case, it just consume more disk space.
[1] http://koji.fedoraproject.org/koji/taskinfo?taskID=8735163