Lazily load set
#374
Merged
Lazily load set
#374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file seems required by `rake` by default. By lazily loading `set`, usages of `rake` that don't use this part of `rake`, don't unnecessarily activate the `set` gem. This seems really minor, I know. But when testing rubygems & bundler, it's interesting for us to be in full control of the gems that are loaded, to make sure that we don't unintentionally activate gems causing our users to be unable to select the version of those gems that they need.
casperisfine
reviewed
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file seems required by
rakeby default. By lazily loadingset, usages ofrakethat don't use this part ofrake, don't unnecessarily activate thesetgem.This seems really minor, I know. But when testing rubygems & bundler, it's interesting for us to be in full control of the gems that are
loaded, to make sure that we don't unintentionally activate gems causing our users to be unable to select the version of those gems that they need.