Update keyword args #326
Merged
Update keyword args #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahonda
added a commit
to yahonda/google-cloud-ruby
that referenced
this pull request
Mar 3, 2020
Related to googleapis#4884 To prepare Ruby 3 keyword arguments support, there are some other gems also need update. `rake` is one of them. * Rake 13.0.0 supports Ruby 3 keyword arguments by ruby/rake#326 * Rake 13 drops Ruby 2.1 or older support by ruby/rake#325 * Gems under `google-cloud-ruby` repository only supports Ruby 2.4 or higher then dropping Ruby 2.1 support should not be an issue. I have bumped all of Rake under `google-cloud-ruby` repository.
quartzmo
added a commit
to googleapis/google-cloud-ruby
that referenced
this pull request
Mar 4, 2020
To prepare Ruby 3 keyword arguments support, there are some other gems also need update. `rake` is one of them. * Rake 13.0.0 supports Ruby 3 keyword arguments by ruby/rake#326 * Rake 13 drops Ruby 2.1 or older support by ruby/rake#325 * Gems under `google-cloud-ruby` repository only supports Ruby 2.4 or higher then dropping Ruby 2.1 support should not be an issue. refs: #4884 pr: #4897
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows recent changes on keyword arguments in ruby 2.7.