Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #189] [Fixes #190] Don't run task if it depends on already invoked but failed task #252

Merged
merged 2 commits into from Mar 19, 2018

Conversation

grzuy
Copy link
Contributor

@grzuy grzuy commented Feb 8, 2018

Fixes #189
Fixes #190

@grzuy grzuy changed the title [Fixes #189] Don't run task if it depends on already invoked but failed task [Fixes #189] [Fixes #190] Don't run task if it depends on already invoked but failed task Feb 23, 2018
rescue RuntimeError
ensure
sleep 0.5
assert !task_two_was_executed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use refute assertion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Done.

@grzuy
Copy link
Contributor Author

grzuy commented Mar 14, 2018

@hsbt Hi, i added additional commit with the requested change.

@hsbt hsbt merged commit a8ebea2 into ruby:master Mar 19, 2018
@grzuy grzuy deleted the fix_multitask_failures branch March 19, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants