Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multitask transitive dependencies unpredictable. #189

Closed
aelsabbahy opened this issue Jan 20, 2017 · 2 comments
Closed

Multitask transitive dependencies unpredictable. #189

aelsabbahy opened this issue Jan 20, 2017 · 2 comments

Comments

@aelsabbahy
Copy link

aelsabbahy commented Jan 20, 2017

Not sure if this is a bug or a misunderstanding on my part. I seem to be getting inconsistent race-condition like behavior with the following setup:

Rakefile:

multitask :default => [:one, :two] do
end

task :two => :one do
  puts "echo 'should not run?'"
end

task :one do
  raise
end

I would expect to never see "should not run?", but I see it intermittently.

for i in {1..10}; do rake 2>/dev/null | grep 'should'; done
echo 'should not run?'
echo 'should not run?'
@grzuy
Copy link
Contributor

grzuy commented Feb 7, 2018

I was able to reproduce.
Working on a fix.

@grzuy
Copy link
Contributor

grzuy commented Feb 23, 2018

The following PR attempts to fix this issue
#252

@hsbt hsbt closed this as completed in #252 Mar 19, 2018
hsbt added a commit that referenced this issue Mar 19, 2018
[Fixes #189] [Fixes #190] Don't run task if it depends on already invoked but failed task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants