Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libressl build fix warning TS_time_cb on libressl expects an long lon… #454

Merged
merged 1 commit into from Sep 27, 2021

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Sep 4, 2021

…g/time_t 64 bits long instead.

TS_time_cb on libressl expects an long long/time_t 64 bits long instead.
@rhenium
Copy link
Member

rhenium commented Sep 27, 2021

Sorry for the delayed response.

I'm changing the target branch because the issue exists in 2.2.x too, not just in master.

@rhenium rhenium changed the base branch from master to maint-2.2 September 27, 2021 02:51
@rhenium rhenium merged commit 52c4d98 into ruby:maint-2.2 Sep 27, 2021
ossl_tsfac_time_cb(struct TS_resp_ctx *ctx, void *data, long *sec, long *usec)
#else
ossl_tsfac_time_cb(struct TS_resp_ctx *ctx, void *data, time_t *sec, long *usec)
#endif
{
*sec = *((long *)data);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (long *) cast should be adjusted as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data points to the lgen_time variable in ossl_tsfac_create_ts(). longtime_t conversion can happen on this line, though.

These can be updated too, but I was reluctant to create more #ifdefs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants