Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links in documention #275

Open
apatniv opened this issue Feb 27, 2023 · 11 comments
Open

Broken links in documention #275

apatniv opened this issue Feb 27, 2023 · 11 comments

Comments

@apatniv
Copy link
Contributor

apatniv commented Feb 27, 2023

I found a couple of broken links in the 'https://ruby.github.io/csv/NEWS_md.html' section. There may be other broken links in other parts of the website as well. If you have no objections, I would like to try and address these broken links.

@kou
Copy link
Member

kou commented Feb 27, 2023

Could you show an example?

@apatniv
Copy link
Contributor Author

apatniv commented Feb 28, 2023

Example:

See highlighted portion the links are not clickable

ruby_csv_example

Comes from
https://raw.githubusercontent.com/ruby/csv/master/NEWS.md

@kou
Copy link
Member

kou commented Feb 28, 2023

Thanks.
You focus on GitHub#N, right?
If it's right, could you open a pull request to use [[GitHub#N](https://github.com/ruby/csv/issues/N)] markup like recent entries?

@apatniv
Copy link
Contributor Author

apatniv commented Mar 1, 2023

Yes. I will make a PR to fix them.

Thank you for quick response.

@binarygit
Copy link

@kou Hello, I noticed that the recipies link is broken.
image

I think the page has been moved. The link to recipies in the API docs are also broken:
image

@kou
Copy link
Member

kou commented Apr 10, 2023

Could you show the URL of the screenshot too?

@binarygit
Copy link

Sorry for replying late. I got held up with things and forgot about this.
The URL is: https://ruby-doc.org/3.2.2/stdlibs/csv/doc/csv/recipes/recipes_rdoc.html

Screenshot_2023-05-01_12-57-31

Screenshot_2023-05-01_12-58-51

@kou
Copy link
Member

kou commented May 1, 2023

The URL is: https://ruby-doc.org/3.2.2/stdlibs/csv/doc/csv/recipes/recipes_rdoc.html

Thanks. But the URL is 404...

@salarconb
Copy link

@kou
Copy link
Member

kou commented Feb 3, 2024

Ah, you said URIs in https://github.com/ruby/csv?tab=readme-ov-file#documentation ?
I wanted to know the URI not URIs for 404.

We can use URIs under https://ruby.github.io/csv/ instead. Could anyone create a PR for this?

@jarrettgreen
Copy link
Contributor

#294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants