Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading warning #324

Open
akimd opened this issue May 12, 2023 · 3 comments
Open

Misleading warning #324

akimd opened this issue May 12, 2023 · 3 comments

Comments

@akimd
Copy link

akimd commented May 12, 2023 •
edited

Hi,

I have lost quite some time because of these messages:

NOTE: RubyProf.profile is deprecated; use Profile.profile instead. It will be removed on or after 2023-06.

So I believed that RubyProf was replaced by some other Profile gem. It took quite some time to understand that the message should actually read

NOTE: RubyProf.profile is deprecated; use RubyProf::Profile.profile instead. It will be removed on or after 2023-06.

That may save other people's time.

Cheers.
@cfis
Copy link
Member

cfis commented May 15, 2023

Sure, that works.

@mackuba
Copy link

mackuba commented Jun 13, 2023

So if calling RubyProf.start etc. is deprecated, does that mean the documentation at https://ruby-prof.github.io is outdated? Because the "convenience API" section there all uses RubyProf directly...

@cfis
Copy link
Member

cfis commented Jun 15, 2023

Yes, the docs need to be updated.

cfis added a commit that referenced this issue Jan 9, 2024
@cfis
Update message for #324
1dc45e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cfis @mackuba @akimd