Sasl fix #281
Merged
Sasl fix #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I recently bumped into this issue while implementing LDAP with sasl via the https://github.com/intridea/omniauth-ldap gem. Any chance we can get this merged in? How can I help? |
|
Thanks all. Not bumping the gem until a few other PRs are merged. |
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Mar 20, 2017
=== Net::LDAP 0.16.0
* Sasl fix {#281}[ruby-ldap/ruby-net-ldap#281]
* enable TLS hostname validation {#279}[ruby-ldap/ruby-net-ldap#279]
* update rubocop to 0.42.0 {#278}[ruby-ldap/ruby-net-ldap#278]
This was referenced Oct 14, 2019
This was referenced Nov 19, 2019
This was referenced Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@syskill - I'm terribly sorry for not simply merging #277. This gem uses Rubocop for some basic style & correctness checks. It reasonably wants us to name
MaxSaslChallengeslike a constant.@jch - This is pretty minor. sasl.rb & connection.rb are the only places in the repo to reference
MaxSaslChallenges, so a rename looks safe. Assuming no CI problems or objections, I'm going to wait a day or two then merge this.