Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export is missing some subdivisions #95

Open
movermeyer opened this issue Nov 29, 2021 · 3 comments
Open

Export is missing some subdivisions #95

movermeyer opened this issue Nov 29, 2021 · 3 comments

Comments

@movermeyer
Copy link
Collaborator

movermeyer commented Nov 29, 2021

Problem?

thor cldr:export --components=subdivisions is missing some subdivisions

In version 35, ruby-cldr exports a data/br/subdivisions.yml file. In v36+, it does not.
This is because the subdivisions have been moved from common/subdivisions/br.xml to common/main/br.xml.

Since ruby-cldr doesn't know about this other location, it drops the information.

Potential Solution?

Look in both locations for subdivision data?

@movermeyer movermeyer changed the title Export missing some subdivisions Export is missing some subdivisions Nov 29, 2021
@movermeyer
Copy link
Collaborator Author

From the spec:

data can be split across multiple files, which can be in multiple directory trees.

For example, the language-dependent data for Japanese in CLDR is present in the following files:

common/collation/ja.xml
common/main/ja.xml
common/rbnf/ja.xml
common/segmentations/ja.xml

The status of the data is the same, whether or not data is split. That is, for the purpose of validation and lookup, all of the data for the above ja.xml files is treated as if it was in a single file.

So ruby-cldr should be combining these files together before doing the lookup.

@movermeyer
Copy link
Collaborator Author

#98 is a necessary improvement, but not sufficient for solving this particular instance (br locale).

The <subdivisions> section of common/main/br.xml is being stripped from the output of the upstream CLDR build process for some reason, so it actually doesn't appear in cldr-staging and the releases. 🤔

@movermeyer
Copy link
Collaborator Author

movermeyer commented Dec 8, 2021

Turns out that there is also a bug in the upstream CLDR build process: https://unicode-org.atlassian.net/browse/CLDR-15228.

Here's a PR to fix it: unicode-org/cldr#1918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant