Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve available locale check in Simple backend #566

Conversation

codealchemy
Copy link
Contributor

This reduces some duplication in the Simple backend by leveraging an existing check (added in 3b6e56e) that will validate either a string and symbol locale against a set of those that are locales available.

This should also improve the performance of related lookups (following a65fffd)

This reduces some duplication in the Simple backend by leveraging a check that will validate both string and symbols against a set of available locales.
@radar
Copy link
Collaborator

radar commented May 13, 2021

I reckon this'll work :) Let's see what CI has to say.

@radar radar merged commit 95612de into ruby-i18n:master May 13, 2021
@codealchemy codealchemy deleted the simple_backend/consolidate-available-locale-check branch May 14, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants