Fix issue with disabled subtrees and pluralization for KeyValue backend #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy to accept this patch as-is. If there is a better implementation, then I am sure someone will submit a patch to do it. Thank you @fatkodima. Also: I think there was just one build on Travis that was breaking (I've since re-run it). If it breaks again, would you mind looking at it and seeing if you could fix it? That would be great :D |
|
@radar ❤️ No problems. |
fatkodima
force-pushed
the
subtrees-bug
branch
from
025004f
to
d04d8ac
Compare
fatkodima
force-pushed
the
subtrees-bug
branch
from
d04d8ac
to
ef2bc12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #325.
The idea behind the fix, roughly speaking: for
KeyValue#lookupwhen value was not found and subtrees are disabled to return some kind of lazy wrapper around possible existing subtree, instead of nil, to check against when searching pluralizations.I'm not super confident about implementation and possibly this can be done in a better way.