Interpolate for arrays #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes unnecessary line
Suggested by @clemens
It covers full use case now. Thankfully to #282 (comment)
This reverts PART of commit ee27f3d. thanks @clemens https://github.com/svenfuchs/i18n/pull/282/files#r37780129
|
Why do all that work and then close it? |
|
I have more interest in merging other my PRs. And gem supporters clearly have limited resources to support project. Decided on my priorities. |
|
You close an non-priority PR after barely 6 days? I just don’t understand the rationale for this at all. Seems like a waste of work.
… On 16 Nov 2017, at 06:39, stereobooster ***@***.***> wrote:
I have more interest in merging other my PRs. And gem supporters clearly have limited resources to support project. Decided on my priorities.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Re-opening because there is interest in #282. |
|
#396 is now closed, so this can be closed. |
Am I missing the relationship between this PR and that PR? Looks like they are not related and it would be great to get this merged. |
radar
approved these changes
Jan 19, 2018
|
Yes, sorry. That was a typo on my end. Thanks @stereobooster and @fatkodima. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased #282