Add missing :many to Polish pluralization #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks @ezwelty! |
|
Do you have an example I can use for the CHANGELOG when I write it? It would be good to include it. What I mean by this is an example of the bug that was happening prior to this merge. |
|
The missing key resulted in I18n::InvalidPluralizationData errors in my Rails app. More specifically, I was using localeapp (Locale/localeapp#189) to generate and manage locale files, which itself relies on this repo. But since the rails-i18n gem (correctly) expects a "many" field in my pl locale files, it threw I18n::InvalidPluralizationData errors. My temporary hack was to manually add the "many" fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.