Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deep interpolation #300

Merged
merged 1 commit into from
Nov 16, 2016
Merged

deep interpolation #300

merged 1 commit into from
Nov 16, 2016

Conversation

fl00r
Copy link
Contributor

@fl00r fl00r commented Dec 5, 2014

Sometimes I need to get a key with a bunch of inner keys and I can't get them interpolated.

people:
  ann: 'Ann is %{ann}'
  john: 'Ann is %{john}'
I18n.t 'people', ann: 'good', john: 'big'
#=> { ann: 'Ann is %{ann}', john: 'John is %{john}' }

# Proposing this approach
I18n.t 'people', ann: 'good', john: 'big', deep_interpolation: true
#=> { ann: 'Ann is good', john: 'John is big' }

@radar
Copy link
Collaborator

radar commented Nov 16, 2016

This looks good to me and I would like to include it in the 0.8.0 release. @fl00r could you please update this branch against master?

@radar radar added this to the 0.8.0 milestone Nov 16, 2016
@radar radar added the waiting label Nov 16, 2016
@fl00r
Copy link
Contributor Author

fl00r commented Nov 16, 2016

:D

joke about 2 years anniversary

Done

@radar radar removed the waiting label Nov 16, 2016
@radar
Copy link
Collaborator

radar commented Nov 16, 2016

Thank you @fl00r!

@radar radar merged commit 157c911 into ruby-i18n:master Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants