Add same_as validator #1850
Merged
Add same_as validator #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaucocustodio
commented
Dec 17, 2018
| @@ -20,6 +20,7 @@ | |||
| config.include Rack::Test::Methods | |||
| config.include Spec::Support::Helpers | |||
| config.raise_errors_for_deprecations! | |||
| config.filter_run_when_matching :focus | |||
There was a problem hiding this comment.
This line is out of scope of this PR, but I find it to be very useful. Can we keep?
|
Great stuff, merged. You can take this from here and make |
|
What about |
|
No, because I mean it should be relative to another value, eg. params do
requires :first
requires :last, greater_than: :first
end |
|
Related, it might make sense to extract (allow extraction of) some of these validators into separate gems at some point. We could have a whole bunch of mathematical validators, password strength validators, etc. |
|
Ok, I thought you were talking about length.. Gt/Lt make sense in this case. I agree with the idea of extracting validators in another gem in the future.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1846.