Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use coveralls-reborn for rails-edge. #1840

Merged
merged 1 commit into from Dec 10, 2018

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 10, 2018

Attempt at fixing CI.

@dblock dblock requested a review from myxoh December 10, 2018 18:32
@grape-bot
Copy link

grape-bot commented Dec 10, 2018

1 Warning
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#1840](https://github.com/ruby-grape/grape/pull/1840): Use coveralls-reborn for rails-edge - [@dblock](https://github.com/dblock).

Generated by 🚫 danger

@myxoh
Copy link
Member

myxoh commented Dec 10, 2018

Thank you

@myxoh myxoh merged commit 669221b into ruby-grape:master Dec 10, 2018
@LeFnord
Copy link
Member

LeFnord commented Dec 10, 2018

@dblock let you run coveralls with that change?

@dblock
Copy link
Member Author

dblock commented Dec 10, 2018

Yep, see https://coveralls.io/builds/20554642 for the build after the merge.

@dblock dblock deleted the coveralls-reborn branch January 16, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants