Support the --all option for Git::Base#fetch #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Couball <jcouball@yahoo.com>
jcouball
force-pushed
the
support_fetch_all
branch
from
c7f5044
to
2f45fa7
Compare
3 tasks
jcouball
changed the title
|
@matthewriedel-flux I'd be interested in your feedback on this PR. |
p-mongo
pushed a commit
to p-mongodb/ruby-git
that referenced
this pull request
May 27, 2022
…' into mine * p/diff-submodule: (36 commits) Support --submodule option to git diff. Support the --all option for git fetch (ruby-git#583) Workaround to get JRuby build working (ruby-git#582) Update README.md (ruby-git#580) Make the directory param to Git.clone optional (ruby-git#578) Make Git::URL.clone_to handle cloning to bare and mirror repos (ruby-git#577) Add Git::URL #parse and #clone_to methods (ruby-git#575) Use the head version of yard (ruby-git#573) Release v1.11.0 Supress unneeded test output (ruby-git#570) Add support for fetch options "--force/-f" and "--prune-tags/-P". (ruby-git#563) Fix bug when grepping lines that contain numbers surrounded by colons (ruby-git#566) remove from maintainer (ruby-git#567) Address command line injection in Git::Lib#fetch Release v1.10.2 (ruby-git#561) Add create-release, setup, and console dev scripts (ruby-git#560) Store tempfile objects to prevent deletion during tests (ruby-git#555) Release v1.10.1 (ruby-git#553) Properly escape double quotes in shell commands on Windows (ruby-git#552) Properly unescape diff paths (ruby-git#504) ... * p/set-url-push: (36 commits) Add :push option to remote_set_url. Support the --all option for git fetch (ruby-git#583) Workaround to get JRuby build working (ruby-git#582) Update README.md (ruby-git#580) Make the directory param to Git.clone optional (ruby-git#578) Make Git::URL.clone_to handle cloning to bare and mirror repos (ruby-git#577) Add Git::URL #parse and #clone_to methods (ruby-git#575) Use the head version of yard (ruby-git#573) Release v1.11.0 Supress unneeded test output (ruby-git#570) Add support for fetch options "--force/-f" and "--prune-tags/-P". (ruby-git#563) Fix bug when grepping lines that contain numbers surrounded by colons (ruby-git#566) remove from maintainer (ruby-git#567) Address command line injection in Git::Lib#fetch Release v1.10.2 (ruby-git#561) Add create-release, setup, and console dev scripts (ruby-git#560) Store tempfile objects to prevent deletion during tests (ruby-git#555) Release v1.10.1 (ruby-git#553) Properly escape double quotes in shell commands on Windows (ruby-git#552) Properly unescape diff paths (ruby-git#504) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Couball jcouball@yahoo.com
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
The fix for GHSA-69p6-wvmq-27gg broke a workflow for some folks (like @matthewriedel-flux) by removing the ability to fetch all remotes.
This adds --all to the list of available flags for the #fetch method. It does not add :a as an alternative flag, as git fetch -a and git fetch --all are not the same thing.
This PR builds on the work by @matthewriedel-flux in PR #579. This PR adds tests to make sure that the git-fetch command line is built properly based on the opts passed to Git::Base#fetch. Additionally, this PR allows leaving off the remote arg as follows:
Note that one difference between this PR and PR #579 is that this will cause an error rather than silently ignoring the given
remotename: