Make Git::URL.clone_to handle cloning to bare and mirror repos #577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Couball jcouball@yahoo.com
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
Git::URL.clone_to was not properly determining the directory to clone to when cloning to a bare or mirror repository. In these cases, the directory should have a
.git
extension added to it.This PR also separates the tests for
Git::URL.parse
andGit::URL.clone_to
as it was hard to understand what exactly was being tested for each.