Add Git::URL .parse and .clone_to methods #575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
In order to address issue #565, we have to figure out where
git clone
cloned a repository to.There are two ways that come to mind:
Scraping the output is questionable because of encoding issues, terminal setup issues, etc. Some testing confirms this.
Attempting to parse the URL also has it's potential issues: parsing all the URL types in the same way that Git does will be difficult to get right.
This PR assumes we will go with parsing the URL and introduces two methods:
Git::URL.parse
andGit::URL.clone_to
.The
parse
method takes a URL as a string and returns a URI object representing the parsed URL.The
clone_to
method takes a URL as a string and returns the directory that git will clone to for that URL.