Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix worktree test when git dir includes symlinks #522

Merged
merged 1 commit into from Jul 6, 2021
Merged

Fix worktree test when git dir includes symlinks #522

merged 1 commit into from Jul 6, 2021

Conversation

jcouball
Copy link
Member

@jcouball jcouball commented Jul 6, 2021

Signed-off-by: James Couball jcouball@yahoo.com

Your checklist for this pull request

馃毃Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

This is a fix for running unit tests on Mac where /tmp is actually a symlink to /private/tmp. Git#dir returns the directory you give it and Worktree#dir returns the expanded path since that is what git workspace list returns.

Some additional thought will have to be put into considering if Git#dir should also return the expanded path.

Signed-off-by: James Couball <jcouball@yahoo.com>
@jcouball jcouball merged commit 8fe479b into ruby-git:master Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant