Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add require 'fiber' for Fiber.current usage. #990

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Add require 'fiber' for Fiber.current usage. #990

merged 1 commit into from
Feb 22, 2023

Conversation

ioquatix
Copy link
Contributor

Fixes #962.

matthewd
matthewd approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@matthewd matthewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a quick glance it looks like the prevailing style is to require stdlib before concurrent/*, FWIW... though it obviously doesn't matter.

@ioquatix ioquatix requested a review from eregon February 20, 2023 06:41
@ioquatix
Copy link
Contributor Author

I think we should also consider moving Fiber.current into core ruby.

@ioquatix
Copy link
Contributor Author

https://bugs.ruby-lang.org/issues/19453

eregon
eregon approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon merged commit 0c6f5a8 into master Feb 22, 2023
@eregon eregon deleted the locals-require-fiber branch February 22, 2023 18:00
eregon added a commit that referenced this pull request Feb 24, 2023
@eregon
Add CHANGELOG for #990
9b15038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewd matthewd matthewd approved these changes

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruby locking is per-fiber, not per-thread.
3 participants
@ioquatix @matthewd @eregon