Add new ConcurrentMap backend for TruffleRuby #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildmaples
force-pushed
the
truffleruby-map-backend
branch
from
c1c7a7f
to
426a88b
Compare
chrisseaton
requested changes
May 7, 2021
| else | ||
| require 'concurrent/collection/map/atomic_reference_map_backend' | ||
| AtomicReferenceMapBackend | ||
| end else |
|
Sorry didn't realise I left my only comment as 'pending'! |
wildmaples
force-pushed
the
truffleruby-map-backend
branch
from
426a88b
to
4b0c1b2
Compare
|
I need to do a bit of exploring to remind myself how to do a release, but I'll get onto that. |
|
@chrisseaton do you need a new release? I'll have time next week. |
|
Yes please! I was going to reach out at some point. I was looking at trying myself but it looks fairly complicated to release. Can you please document how you do it as you go through the steps? Thanks very much. |
|
Ok, I'll see what I can do about improving the release doc. |
|
I've flatten the condition 382550c |
|
The build doc was updated in 5f06b9b |
|
released. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've created a new backend for more efficient mapping on TruffleRuby using Java's ConcurrentHashMap library - oracle/truffleruby#2339
The new backend is faster than the previous implementation for TruffleRuby,
AtomicReferenceMapBackend. And also faster than MRI and JRuby:Changes
TruffleRubyMapBackendthat inherits from the newTruffleRuby::ConcurrentMapTruffleRubyMapBackendbackend forConcurrent::Mapon TruffleRuby if availableTesting
The new backend has been tested locally and passes the
map_specon this gem