Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should we use new c macros included with rubyc? #897

Open
dsisnero opened this issue Jan 5, 2021 · 1 comment
Open

should we use new c macros included with rubyc? #897

dsisnero opened this issue Jan 5, 2021 · 1 comment
Labels
enhancement Adding features, adding tests, improving documentation. looking-for-contributor We are looking for a contributor to help with this issue.

Comments

@dsisnero
Copy link

dsisnero commented Jan 5, 2021

with ruby/ruby#3983 , rubyc includes c macros to do atomic operations. should we use these for the atomic operations?

  • Operating system: linux / mac / win
  • Ruby implementation: Ruby / JRuby / TruffleRuby / Rubinius
  • concurrent-ruby version: x.y.z
  • concurrent-ruby-ext installed: yes / no
  • concurrent-ruby-edge used: yes / no
@pitr-ch pitr-ch added enhancement Adding features, adding tests, improving documentation. looking-for-contributor We are looking for a contributor to help with this issue. labels Jan 18, 2021
@pitr-ch
Copy link
Member

pitr-ch commented Jan 18, 2021

This is a good idea, thank you for letting me know. Although, the implementation in concurrent-ruby should use these conditionally only when available since it has to support old Ruby versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding features, adding tests, improving documentation. looking-for-contributor We are looking for a contributor to help with this issue.
Projects
None yet
Development

No branches or pull requests

2 participants