Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition in TVar #885

Closed
chrisseaton opened this issue Sep 20, 2020 · 1 comment
Closed

Race condition in TVar #885

chrisseaton opened this issue Sep 20, 2020 · 1 comment
Assignees
@chrisseaton
Labels
bug A bug in the library or documentation.

Comments

@chrisseaton
Copy link
Member

When a TVar is first written to, the fact that it's been locked isn't recorded until after the check if any previous reads are now stale. If the transaction aborts at this point due to stale reads the TVar is left locked.
chrisseaton added a commit that referenced this issue Sep 20, 2020
@chrisseaton
Fix race condition in TVar for stale reads, fixes #885
2cb1fc4
chrisseaton added a commit that referenced this issue Sep 20, 2020
@chrisseaton
Fix race condition in TVar for stale reads, fixes #885
e718a78
headius added a commit that referenced this issue Sep 21, 2020
@headius
Merge pull request #886 from ruby-concurrency/stale-reads-race-condition
31669c6 
Fix race condition in TVar for stale reads, fixes #885
@pitr-ch
Copy link
Member

pitr-ch commented Sep 21, 2020

Thanks for the fix.

@pitr-ch pitr-ch added the bug A bug in the library or documentation. label Sep 21, 2020
@pitr-ch pitr-ch assigned pitr-ch and chrisseaton and unassigned pitr-ch Sep 21, 2020
This was referenced Mar 15, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisseaton chrisseaton

Labels
bug A bug in the library or documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump concurrent-ruby from 1.1.7 to 1.1.8 YoheiZuho/mastodon
2 participants
@pitr-ch @chrisseaton