New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ``` from LICENSE.md #877
Conversation
The leading ``` makes it hard for [licensed](https://github.com/github/licensed/) to parse the license. Can we drop them?
To expand on this, does the license need to be a markdown file? |
If the intent is to have it detected as the MIT License, I believe there is more you'd have to fix with the license file. While it does include the MIT license text, it also includes a link and extra text on the copyright line, which may also be part of why licensed is confused. Additionally, if you look at the fork's repository page, GitHub still shows a generic "View License" link -- suggesting that licensed is still confused about which license the repository is under. Although it's possible that licensed only checks against the master branch, as the fork's master branch still has the backticks. @adamruzicka I've seen some repositories that will use no extension, some that will use .MD, and a couple that even use .TXT. As far as I'm aware, the file extension does not matter -- I believe it only matters that the filename is the case-insensitive name |
I assume
|
- make sure it works in YARD
I've changed it to txt file and made sure it works in YARD. Will it work for you like this? |
@pitr-ch that looks good to me! |
The leading ``` make it hard for licensed to parse the license. Can we drop them?