Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child promise state not set to :pending immediately after #execute when parent has completed #866

Merged
merged 1 commit into from Jun 4, 2021

Conversation

pelly
Copy link
Contributor

@pelly pelly commented Apr 24, 2020

  1. Create a parent promise and wait for it to complete
  2. Create a child promise chain off the parent (via a call to then, on_success, etc)
  3. Call execute on the child promise
  4. Immediately check the state of the child promise
  5. This state will be :unscheduled.

Expectation: It should be :pending.

…, creating a child promise (via #then, #on_success, etc) and calling child_promise.execute.state return :unscheduled. It should return :pending
@pitr-ch
Copy link
Member

pitr-ch commented Jun 4, 2021

Thank you for the fix!

@pitr-ch pitr-ch self-requested a review June 4, 2021 18:31
@pitr-ch pitr-ch added the bug A bug in the library or documentation. label Jun 4, 2021
@pitr-ch pitr-ch merged commit b57b483 into ruby-concurrency:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug in the library or documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants