Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated documentation about Concurrent::Async and constructors? #863

Closed
markiz opened this issue Apr 9, 2020 · 2 comments · Fixed by #878
Closed

Outdated documentation about Concurrent::Async and constructors? #863

markiz opened this issue Apr 9, 2020 · 2 comments · Fixed by #878
Assignees
Labels
bug A bug in the library or documentation.

Comments

@markiz
Copy link
Contributor

markiz commented Apr 9, 2020

# When defining a constructor it is critical that the first line be a call to
# `super` with no arguments. The `super` method initializes the background
# thread and other asynchronous components.
#
# ```
# class BackgroundLogger
# include Concurrent::Async
#
# def initialize(level)
# super()
# @logger = Logger.new(STDOUT)
# @logger.level = level
# end
#
# def info(msg)
# @logger.info(msg)
# end
# end
# ```

I don't think that is necessary anymore, since everything related to initialization now lives in .new?

@pitr-ch pitr-ch added bug A bug in the library or documentation. looking-for-contributor We are looking for a contributor to help with this issue. labels Jul 20, 2020
@pitr-ch
Copy link
Member

pitr-ch commented Jul 20, 2020

You are right, Thanks! Could you open a PR removing it?

@markiz
Copy link
Contributor Author

markiz commented Jul 21, 2020

@pitr-ch Sure, #878

@pitr-ch pitr-ch assigned pitr-ch and markiz and unassigned pitr-ch Jul 21, 2020
@pitr-ch pitr-ch removed the looking-for-contributor We are looking for a contributor to help with this issue. label Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug in the library or documentation.
Projects
None yet
2 participants