Introduce ThreadPoolExecutor without a Queue #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had a brief look, NICE! Good idea how to get around the problem with 0 already having a meaning. |
|
Thanks. Look forward to your feedback. |
|
@pitr-ch any update on this ? |
pitr-ch
reviewed
Mar 1, 2020
lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb
Outdated
Show resolved
Hide resolved
lib/concurrent-ruby/concurrent/executor/ruby_thread_pool_executor.rb
Outdated
Show resolved
Hide resolved
This adds the ability for a ThreadPoolExecutor to have a queue depth of 0. This is useful if you'd like to perform the rejection handler if no available threads are availabile. This is analogous to Java's use of SynchronousQueue in ThreadPoolExecutor. See https://stackoverflow.com/a/10186825/143733 for more details
pitr-ch
force-pushed
the
faridzakaria/bounded_queue
branch
from
754b4c4
to
7fa7e82
Compare
|
I've checked and fixed documentation. I had to rebase on master. |
Co-Authored-By: Chalupa Petr <git@pitr.ch>
Co-Authored-By: Chalupa Petr <git@pitr.ch>
|
Thanks @pitr-ch |
pitr-ch
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability for a ThreadPoolExecutor to have a queue
depth of 0.
This is useful if you'd like to perform the rejection handler if no
available threads are availabile.
This is analogous to Java's use of SynchronousQueue in
ThreadPoolExecutor.
See https://stackoverflow.com/a/10186825/143733 for more details