Make CRuby Set thread safe #847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow similar pattern for Rbx to wrap every superclass (::Set) instance method with a Monitor (which is re-entrant). Included is a test that I believe *would* occasionally fail if Set was not thread safe. fixes ruby-concurrency#796
fzakaria
commented
Feb 10, 2020
|
|
||
| class CRubySet < ::Set | ||
| def initialize(*args) | ||
| self.send(:_mon_initialize) |
There was a problem hiding this comment.
Without this -- certain Sets are being created not through initialize
I would see:
when initializing with a block argument
concurrent-ruby/concurrent/thread_safe/util/data_structures.rb:43:
warning: instance variable @_monitor not initialized
I'm not certain how the Set is being initialized without going through:
def self.new(*args)
obj = super(*args)
obj.send(:_mon_initialize)
obj
endTBH i'm
fzakaria
commented
Feb 10, 2020
| @@ -55,6 +55,33 @@ module Concurrent | |||
| end.map(&:join) | |||
| expect(set).to be_empty | |||
| end | |||
|
|
|||
| it 'force context switch' do | |||
There was a problem hiding this comment.
writing a test for this is actually not easy lol.
What this ended up testing was that during a method of set it grabs a monitor and locks out any other changes.
expect(set.add?(1)).to eq setthe above line should occasionally return nil if the methods were not synchronized.
|
Replaced by #911 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow similar pattern for Rbx to wrap every superclass (::Set) instance
method with a Monitor (which is re-entrant).
Included is a test that I believe would occasionally fail
if Set was not thread safe.
fixes #796