Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put 1.9.3 support back #769

Merged
merged 1 commit into from Nov 5, 2018
Merged

Put 1.9.3 support back #769

merged 1 commit into from Nov 5, 2018

Conversation

pitr-ch
Copy link
Member

@pitr-ch pitr-ch commented Nov 1, 2018

fix #768

@ghost ghost assigned pitr-ch Nov 1, 2018
@ghost ghost added the in progress label Nov 1, 2018
@nijikon
Copy link

nijikon commented Nov 2, 2018

@pitr-ch as I appreciate you fixing this, I don't think 1.9.3 should still be supported. Support for it ended at 23rd of February 2015, https://www.ruby-lang.org/en/news/2015/02/23/support-for-ruby-1-9-3-has-ended/. People should upgrade or just use the last available version of a gem for their ruby version. We should not support old stuff for forever.

@nijikon
Copy link

nijikon commented Nov 2, 2018

To be honest, we should support version >= 2.3, people should not be encouraged to run old ruby versions.

@pitr-ch
Copy link
Member Author

pitr-ch commented Nov 5, 2018

With 2 indirections, 20% of all existing gems depend on concurrent-ruby. I have to be extra careful regarding compatibility. I plan to drop the support for old Ruby version eventually but I want to communicate it first with authors of the libraries depending on concurrent-ruby. Not dropping it all of a sudden as I did in 1.1.

@nijikon
Copy link

nijikon commented Nov 5, 2018

Agreed, I would opt for bumping to 2.0 and drop support for < 2.3.

@nijikon
Copy link

nijikon commented Nov 5, 2018

Or maybe 2.0 is too big of a bump, I guess 1.1 would be fine for me if we would communicate it in the changelog as breaking changes.

@pitr-ch pitr-ch merged commit 2aa342b into master Nov 5, 2018
@ghost ghost removed the in progress label Nov 5, 2018
@pitr-ch pitr-ch deleted the 193 branch November 5, 2018 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.1.0 is a breaking build but wasn't marked as such
2 participants