Fix wrong expected exception in spec assertion #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! Afaik the tests were disabled because the channel implementation is not stable and the specs intermittently fail. Fixing that is a larger task. |
|
So I would rather leave it disabled. |
It's pretty straightforward that an `ArgumentError` is raised here. I wonder if this was changed to `RejectedExecutionError` because somehow that was happening instead due to cross-spec interference.
ivoanjo
force-pushed
the
fix-broken-channel-spec
branch
from
a36aa32
to
f74aece
Compare
|
@pitr-ch updated! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed the spec and re-enabled running on travis as otherwise it seems harmless (famous last words?).