Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two tests fail on Alpine Linux armhf, running with -ext #689

Closed
jirutka opened this issue Dec 26, 2017 · 3 comments · Fixed by #699
Closed

Two tests fail on Alpine Linux armhf, running with -ext #689

jirutka opened this issue Dec 26, 2017 · 3 comments · Fixed by #699
Labels
bug A bug in the library or documentation. high-priority Should be done ASAP. pending Waiting for response, blocked by other problem, etc.

Comments

@jirutka
Copy link
Contributor

jirutka commented Dec 26, 2017

I’m getting the following failures on Alpine Linux armhf. All tests pass on other architectures, so the problem is related to armhf platform.

Failures:

  1) Concurrent::Map #inspect
     Failure/Error: expect(Concurrent::Map.new.inspect).to match(regexp)

       expected "#<Concurrent::Map:0x-537308c8 entries=0 default_proc=nil>" to match /\A#<Concurrent::Map:0x[0-9a-f]+ entries=[0-9]+ default_proc=.*>\Z/i
       Diff:
       @@ -1,2 +1,2 @@
       -/\A#<Concurrent::Map:0x[0-9a-f]+ entries=[0-9]+ default_proc=.*>\Z/i
       +"#<Concurrent::Map:0x-537308c8 entries=0 default_proc=nil>"
     # ./spec/concurrent/map_spec.rb:798:in `block (2 levels) in <module:Concurrent>'

  2) Concurrent::Promises Future constructs promise like tree
     Failure/Error: expect(head.to_s).to match /<#Concurrent::Promises::Future:0x[\da-f]+ pending>/

       expected "<#Concurrent::Promises::Future:0x..facab5450 pending>" to match /<#Concurrent::Promises::Future:0x[\da-f]+ pending>/
       Diff:
       @@ -1,2 +1,2 @@
       -/<#Concurrent::Promises::Future:0x[\da-f]+ pending>/
       +"<#Concurrent::Promises::Future:0x..facab5450 pending>"
     # ./spec/concurrent/edge/promises_spec.rb:374:in `block (3 levels) in <top (required)>'

Finished in 2 minutes 22.9 seconds (files took 3.8 seconds to load)
2047 examples, 2 failures, 7 pending

  • Operating system: linux
  • concurrent-ruby version: 1.0.5
  • concurrent-ruby-ext installed: yes
  • concurrent-ruby-edge used: no
@pitr-ch
Copy link
Member

pitr-ch commented Feb 21, 2018

Hi, thanks for reporting! #651 partially fixes it. I am looking at the rest.

@pitr-ch pitr-ch added this to the 1.0.6 milestone Feb 21, 2018
@pitr-ch pitr-ch added the bug A bug in the library or documentation. label Feb 21, 2018
@pitr-ch
Copy link
Member

pitr-ch commented Feb 21, 2018

#699 should fix the rest, @jirutka could you verify?

@pitr-ch
Copy link
Member

pitr-ch commented Feb 21, 2018

Both fixes are merged, @jirutka I'll keep this open, could you test master that it passes?

@pitr-ch pitr-ch reopened this Feb 21, 2018
@pitr-ch pitr-ch added in progress pending Waiting for response, blocked by other problem, etc. labels May 23, 2018
@pitr-ch pitr-ch added the patch label Jun 18, 2018
@pitr-ch pitr-ch added high-priority Should be done ASAP. and removed patch labels Jun 29, 2018
@pitr-ch pitr-ch closed this as completed Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug in the library or documentation. high-priority Should be done ASAP. pending Waiting for response, blocked by other problem, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants