Avoid RSpec warnings about raise_error #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
changed the title
olleolleolle
changed the title
olleolleolle
changed the title
olleolleolle
changed the title
|
This fix does not change the status of the JRuby issues - those builds stall after |
olleolleolle
changed the title
pitr-ch
force-pushed
the
fix/avoid-rspec-actor-spec
branch
from
47dd5b4
to
3e438b9
Compare
ghost
assigned 
|
Rebased on master to rerun CI. |
pitr-ch
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids an RSpec warning about
raise_errorwithout any arguments.While fixing this output warning, I found that one test which had been using a bare expectation to
raise_erroractually masked a NameError, just like the RSpec warning said it could.