Fix Map#each and #each_pair not returning enumerator outside of MRI #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SynchronizedMapBackend, by definition, uses a lock around every operation, and thus could never pass a test that checks that updates and reads can happen concurrently.
When no block was passed to Map#each_pair or its alias Map#each, the NonConcurrentMapBackend would return an enumerator, which would allow enumerable methods to be used on a Map. But the alternate Map backends, JRubyMapBackend and AtomicReferenceMapBackend did not implement the same logic. As a fix, let's move the logic down to the shared Map class, so all implementations can use it. Fixes #643
pitr-ch
approved these changes
Apr 2, 2017
|
Hey @pitr-ch any chance this can get released? I just got bitten by it again (and it's been so long I didn't even remember I had already fixed it 😭). 😀 |
|
Sorry, I am catching up on c-r after busy summer, I'll get a release out. |
|
Great, thanks! 👍 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no block was passed to Map#each_pair or its alias Map#each, the NonConcurrentMapBackend would return an enumerator, which would allow enumerable methods to be used on a Map.
But the alternate Map backends, JRubyMapBackend and AtomicReferenceMapBackend did not implement the same logic.
As a fix, let's move the logic down to the shared Map class, so all implementations can use it.
Fixes #643