Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread Safe Set implementation #564

Closed
thedrow opened this issue Aug 2, 2016 · 5 comments
Closed

Thread Safe Set implementation #564

thedrow opened this issue Aug 2, 2016 · 5 comments
Labels
enhancement Adding features, adding tests, improving documentation. looking-for-contributor We are looking for a contributor to help with this issue.

Comments

@thedrow
Copy link
Contributor

thedrow commented Aug 2, 2016 •
edited by pitr-ch

Currently there is no Thread Safe set implementation in this library and I found a need for it.
What would it take to add one?
@pitr-ch
Copy link
Member

pitr-ch commented Aug 2, 2016

As a quick dirty solution you could use the Concurrent::Hash's keys as set, inserting always true for values. If you look at stdlib's Set it does the same. We look into adding Set for convenience later.

@pitr-ch pitr-ch added the enhancement Adding features, adding tests, improving documentation. label Aug 2, 2016
@thedrow
Copy link
Contributor Author

thedrow commented Aug 3, 2016

Is there a reason not to save the memory for the values?

@pitr-ch
Copy link
Member

pitr-ch commented Aug 3, 2016

Not really, it's just that nobody wrote the Set implementation yet.

@jdantonio
Copy link
Member

@thedrow Thank you very much for the suggestion!

What would it take to add one?

I'd be happy to look at a PR which adds this feature to Edge. Unfortunately none of the core maintainers are available to work on this right now. Our top priorities are bugs and the upcoming 2.0 effort. Once 2.0 is complete we can revisit the idea. In the mean time I'm going to pause this issue and leave it open.

@pitr-ch pitr-ch removed the paused label Feb 23, 2017
@pitr-ch pitr-ch added this to the 2.0.0 milestone Feb 23, 2017
@haridutt12 haridutt12 mentioned this issue Jul 13, 2017
Merged
@pitr-ch pitr-ch added the looking-for-contributor We are looking for a contributor to help with this issue. label Jul 6, 2018
@pitr-ch
Copy link
Member

pitr-ch commented Jul 6, 2018

Done in #666

@pitr-ch pitr-ch closed this as completed Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Adding features, adding tests, improving documentation. looking-for-contributor We are looking for a contributor to help with this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thedrow @jdantonio @pitr-ch