Add new Style/RedundantSelfAssignmentBranch cop
#9999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds new `Style/RedundantSelfAssignmentBranch` cop. It checks where conditional branch makes redundant self-assignment. ```ruby # bad foo = condition ? bar : foo # good foo = bar if condition ``` Redundancy for self-assignment to `elsif` may also be detected in future, but this PR implements ternary operator-centric detection.
koic
force-pushed
the
add_new_style_redundant_self_assignment_branch_cop
branch
from
89ee5f1
to
178e0a0
Compare
|
Nice! Usually this is a bug, because |
|
Nice new cop! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new
Style/RedundantSelfAssignmentBranchcop.It checks where conditional branch makes redundant self-assignment.
Redundancy for self-assignment to
elsifmay also be detected in future, but this PR implements ternary operator-centric detection.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.