Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Style/IdenticalConditionalBranches as unsafe auto-correction #9985

Conversation

koic
Copy link
Member

@koic koic commented Aug 6, 2021

Follow up to #9982 (comment)

This PR marks Style/IdenticalConditionalBranches as unsafe auto-correction.

Style/IdenticalConditionalBranches cop is marked unsafe auto-correction as the order of method calls must be guaranteed in the following case:

if method_that_modifies_global_state # 1
  method_that_relies_on_global_state # 2
  foo                                # 3
else
  method_that_relies_on_global_state # 2
  bar                                # 3
end

In such a case, auto-correction may change the invocation order.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the mark_unsafe_autocorrect_for_style_identical_conditional_branches branch from fbb5f3c to 83212ef Compare August 6, 2021 03:00
Follow up to rubocop#9982 (comment)

This PR marks `Style/IdenticalConditionalBranches` as unsafe auto-correction.

`Style/IdenticalConditionalBranches` cop is marked unsafe auto-correction
as the order of method calls must be guaranteed in the following case:

```ruby
if method_that_modifies_global_state # 1
  method_that_relies_on_global_state # 2
  foo                                # 3
else
  method_that_relies_on_global_state # 2
  bar                                # 3
end
```

In such a case, auto-correction may change the invocation order.
@koic koic force-pushed the mark_unsafe_autocorrect_for_style_identical_conditional_branches branch from 83212ef to 6059c6d Compare August 6, 2021 03:08
@koic koic merged commit 37134fb into rubocop:master Aug 7, 2021
@koic koic deleted the mark_unsafe_autocorrect_for_style_identical_conditional_branches branch August 7, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants