Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Style/Semicolon to add autocorrection #9979

Merged
merged 2 commits into from Aug 4, 2021

Conversation

dvandersluis
Copy link
Member

I noticed that Style/Semicolon doesn't do autocorrection, so this adds basic auto-correction (replaces semicolons between statements with a new line, indentation will be fixed by other cops).

A small autocorrection conflict between this and Style/SingleLineMethods is prevented by adding that to autocorrect_incompatible_with (which we need to document somewhere because I can never remember what it's called 😬).


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

When a semicolon is found between expressions, it is replaced with a newline. In order to avoid adding multiple newlines, when the semicolons are making a single-line method, autocorrection is disabled in favour of the autocorrection from `Style/SingleLineMethods`.
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 4, 2021

A small autocorrection conflict between this and Style/SingleLineMethods is prevented by adding that to autocorrect_incompatible_with (which we need to document somewhere because I can never remember what it's called 😬).

Sounds like we need one more PR for this! ;)

Good work!

@bbatsov bbatsov merged commit b989ed7 into rubocop:master Aug 4, 2021
@dvandersluis dvandersluis deleted the style/semicolon branch September 14, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants