Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't register an offense when sort method has arguments #9970

Merged
merged 1 commit into from Aug 5, 2021

Conversation

mtsmfm
Copy link
Contributor

@mtsmfm mtsmfm commented Aug 1, 2021

Currently, Style/RedundantSort doesn't allow sort(_id: 1).first and suggests min(_id: 1) but it's not equivalent.

require 'bundler/inline'

gemfile do
  source 'https://rubygems.org'

  gem 'mongo'
end

mongo_client = Mongo::Client.new('mongodb://mongo/test')
mongo_client['users'].find.sort(_id: 1).first
# => nil

mongo_client['users'].find.min(_id: 1)
# TypeError: no implicit conversion of Hash into Integer

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
    * [ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic merged commit 4460b6d into rubocop:master Aug 5, 2021
@koic
Copy link
Member

koic commented Aug 5, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants