Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #9852] Fix empty line after guard clause with and and heredoc #9876

Conversation

AndreiEres
Copy link

@AndreiEres AndreiEres commented Jun 13, 2021

Fixes #9852


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@AndreiEres AndreiEres force-pushed the fix/empty_line_after_guard_clause_with_and_and_heredoc branch from f94c19e to 34af9af Compare June 13, 2021 21:00
@AndreiEres AndreiEres changed the title Fix empty line after guard clause with and and heredoc [Fix #9852] Fix empty line after guard clause with and and heredoc Jun 13, 2021
@AndreiEres AndreiEres force-pushed the fix/empty_line_after_guard_clause_with_and_and_heredoc branch from 34af9af to bd3d764 Compare June 13, 2021 21:09
@koic
Copy link
Member

koic commented Jun 13, 2021

Thanks for fixing the issue. Can you squash your commits into one?

@AndreiEres AndreiEres force-pushed the fix/empty_line_after_guard_clause_with_and_and_heredoc branch from bd3d764 to 83a4c1e Compare June 14, 2021 06:15
@AndreiEres
Copy link
Author

Thanks for fixing the issue. Can you squash your commits into one?

Done

@bbatsov bbatsov merged commit 76fc82b into rubocop:master Jun 14, 2021
@AndreiEres AndreiEres deleted the fix/empty_line_after_guard_clause_with_and_and_heredoc branch June 14, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout/EmptyLineAfterGuardClause doesn't seem to play nice with heredoc and return
3 participants