Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support one-line pattern matching syntax #9873

Merged
merged 1 commit into from Jun 13, 2021

Conversation

koic
Copy link
Member

@koic koic commented Jun 12, 2021

This PR supports one-line pattern matching syntax for Layout/SpaceAroundKeyword and Layout/SpaceAroundOperators.

match-pattern node changes differently in Ruby 2.7 and Ruby 3.0.

Ruby 2.7 (Parser::Ruby27)

% ruby-parse -e '42 in foo'
(match-pattern
  (int 42)
  (match-var :foo))

Ruby 3.0 (Parser::Ruby30)

% ruby-parse -e '42 => foo'
(match-pattern
  (int 42)
  (match-var :foo))

And one-line in syntax that represents one-line pattern maching changes
from match-pattern node to match-pattern-p in Ruby 3.0.

% ruby-parse -e '42 in foo'
(match-pattern-p
(int 42)
  (match-var :foo))

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR supports one-line pattern matching syntax for `Layout/SpaceAroundKeyword`
and `Layout/SpaceAroundOperators`.

`match-pattern` node changes differently in Ruby 2.7 and Ruby 3.0.

## Ruby 2.7 (`Parser::Ruby27`)

```console
% ruby-parse -e '42 in foo'
(match-pattern
  (int 42)
  (match-var :foo))
```

## Ruby 3.0 (`Parser::Ruby30`)

```console
% ruby-parse -e '42 => foo'
(match-pattern
  (int 42)
  (match-var :foo))
```

And one-line `in` syntax that represents one-line pattern maching changes
from `match-pattern` node to `match-pattern-p` in Ruby 3.0.

```console
% ruby-parse -e '42 in foo'
(match-pattern-p
(int 42)
  (match-var :foo))
```
@koic koic force-pushed the support_one_line_pattern_matching branch from 82f8572 to b278827 Compare June 12, 2021 05:46
@bbatsov bbatsov merged commit 4fed3f7 into rubocop:master Jun 13, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 13, 2021

Thanks!

@koic koic deleted the support_one_line_pattern_matching branch June 13, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants