Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect auto-correct for Layout/DotPosition #9867

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jun 11, 2021

This PR fixes the following incorrect auto-correct for Layout/DotPosition when using only dot line.

% cat example.rb
foo
  .bar
  .
  baz

% rubocop --only Layout/DotPosition -a
(snip)

Inspecting 1 file
C

Offenses:

example.rb:3:3: C: [Corrected] Layout/DotPosition: Place the . on the
next line, together with the method name.
  .
  ^

1 file inspected, 1 offense detected, 1 offense corrected

Before

% cat example.rb
foo
  .bar

  .baz

% ruby -c example.rb
example.rb:4: syntax error, unexpected '.', expecting end-of-input
  .baz

After

% cat example.rb
foo
  .bar
  .baz

% ruby -c example.rb
Syntax OK

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic koic force-pushed the fix_incorrect_autocorrect_for_layout_dot_position branch from 89d572d to b6f543e Compare June 11, 2021 02:52
This PR fixes the following incorrect auto-correct for `Layout/DotPosition`
when using only dot line.

```console
% cat example.rb
foo
  .bar
  .
  baz

% rubocop --only Layout/DotPosition -a
(snip)

Inspecting 1 file
C

Offenses:

example.rb:3:3: C: [Corrected] Layout/DotPosition: Place the . on the
next line, together with the method name.
  .
  ^

1 file inspected, 1 offense detected, 1 offense corrected
```

## Before

```consle
% cat example.rb
foo
  .bar

  .baz

% ruby -c example.rb
example.rb:4: syntax error, unexpected '.', expecting end-of-input
  .baz
```

## After

```console
% cat example.rb
foo
  .bar
  .baz

% ruby -c example.rb
Syntax OK
```
@koic koic force-pushed the fix_incorrect_autocorrect_for_layout_dot_position branch from b6f543e to b2dcb10 Compare June 11, 2021 02:54
@bbatsov bbatsov merged commit a20493d into rubocop:master Jun 11, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 11, 2021

Thanks!

@koic koic deleted the fix_incorrect_autocorrect_for_layout_dot_position branch June 11, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants